feat: add pytest-bdd and BDD scenario coverage#3
Merged
dereknorrbom merged 2 commits intodevelopfrom Apr 13, 2026
Merged
Conversation
- Add pytest-bdd>=7.0 to dev dependencies - Create tests/features/ and tests/steps/ directory structure - Add scan_modes.feature with 3 scenarios covering default and standard-findings modes - Document BDD workflow and directory layout in AGENTS.md
…etection, and repo config - Add tests/conftest.py with shared helpers and cli_ctx fixture - Add cli_output.feature: exit codes, verbose/quiet output, lang filter, missing SARIF - Add findings_filtering.feature: --files, --rule, --limit, --offset, third-party excludes - Add language_detection.feature: auto-detect, ignore dirs, Actions, sort order - Add repo_config.feature: config loading, CLI override precedence, disable config - Add corresponding step definitions in tests/steps/ - 172 tests passing (129 unit + 43 BDD)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest-bddto dev dependencies and wire it into the existingmake test/pytest tests/invocation — no CI changes requiredtests/conftest.pywith shared helpers (run_rcql,make_report_dir,write_sarif_with_paths,write_repo_config) andcli_ctxfixturescan_modes.feature— default vs standard-findings mode, suite resolutioncli_output.feature— exit codes, verbose/quiet, lang filter, missing SARIFfindings_filtering.feature—--files,--rule,--limit,--offset, third-party excludeslanguage_detection.feature— auto-detect, ignore dirs, Actions, sort orderrepo_config.feature— config loading, CLI override precedence,--config ''AGENTS.mdTests
172 tests passing across all scenarios (129 unit + 43 BDD).